Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tests which depend on ECS as expected fail; separate integration and unit tests #609

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

mfisher87
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 14, 2024

Binder 👈 Launch a binder notebook on this branch for commit d917999

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 084ab7d

Binder 👈 Launch a binder notebook on this branch for commit 3430c89

Binder 👈 Launch a binder notebook on this branch for commit b773376

Binder 👈 Launch a binder notebook on this branch for commit 25346ea

@mfisher87 mfisher87 added the review::quick This change should not require more than 10 minutes to review label Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (0f2cfeb) to head (25346ea).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #609      +/-   ##
===============================================
+ Coverage        65.47%   66.68%   +1.21%     
===============================================
  Files               38       36       -2     
  Lines             3134     3077      -57     
  Branches           601      594       -7     
===============================================
  Hits              2052     2052              
+ Misses             991      935      -56     
+ Partials            91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfisher87 mfisher87 changed the title Mark tests which depend on ECS as expected fail Mark tests which depend on ECS as expected fail; separate integration and unit tests Sep 18, 2024
Copy link
Member

@JessicaS11 JessicaS11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the init.py and conftest.py files remain at the icepyx/tests directory level? Otherwise the integration tests won't pick up the auth info from conftest.

@mfisher87
Copy link
Member Author

mfisher87 commented Sep 25, 2024

Yes, excellent catch, thank you! I thought I had the conftest.py in the integration directory, but clearly not! Both types of tests turn out to require fixtures from conftest.py. I'd recommend having one conftest.py for unit tests and another for integration tests, but didn't want to increase the scope of the PR :) The __init__.py seems to not be needed.

b773376

@mfisher87
Copy link
Member Author

Integration tests run:

https://github.com/icesat2py/icepyx/actions/runs/11040360996/job/30668167255

The tests marked xfail have status XPASS (unexpected pass), which is considered OK by default.

@mfisher87 mfisher87 dismissed JessicaS11’s stale review September 26, 2024 00:09

Resolved requests

@JessicaS11
Copy link
Member

Something funny happened with the timing and I can't get the unit tests to run and report a status based on 9a9d67a. But they were passing before the UML updates so I'm going to use admin to merge. See #618.

@JessicaS11 JessicaS11 merged commit 74ca632 into development Sep 26, 2024
2 checks passed
@JessicaS11 JessicaS11 deleted the disable-ecs-tests branch September 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review::quick This change should not require more than 10 minutes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants